Skip to content

fix: Move keyword routing tests to e2e framework and validate matched_keywords #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: Move keyword routing tests to e2e framework and validate matched_keywords #694

wants to merge 3 commits into from

Conversation

@szedan-rh
Copy link
Contributor

@szedan-rh szedan-rh commented Nov 19, 2025

  • Relocate test files to e2e/testcases/ to trigger CI
  • Add matched_keywords assertion in keyword routing E2E test
  • Remove unused test types and old unit test directory

@netlify
Copy link

netlify bot commented Nov 19, 2025 •
edited
Loading

✅ Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit c51ae0e
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6923143eff30520008af0609
😎 Deploy Preview https://deploy-preview-694--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025 •
edited
Loading

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 e2e

Owners: @Xunzhuo
Files changed:

  • e2e/profiles/routing-strategies/config.yaml
  • e2e/profiles/routing-strategies/profile.go
  • e2e/profiles/routing-strategies/values.yaml
  • e2e/testcases/testdata/keyword_routing_cases.json
  • e2e/cmd/e2e/main.go
  • e2e/testcases/keyword_routing.go

📁 Root Directory

Owners: @rootfs, @Xunzhuo
Files changed:

  • .github/workflows/integration-test-k8s.yml
vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@szedan-rh szedan-rh marked this pull request as ready for review November 19, 2025 16:11
@szedan-rh szedan-rh mentioned this pull request Nov 19, 2025
Merged
6 tasks
@szedan-rh
Copy link
Contributor Author

szedan-rh commented Nov 19, 2025

@Xunzhuo / @srini-abhiram - PTAL

rootfs
rootfs previously approved these changes Nov 19, 2025
View reviewed changes
@szedan-rh szedan-rh mentioned this pull request Nov 19, 2025
Closed
5 tasks
@Xunzhuo
Copy link
Member

Xunzhuo commented Nov 19, 2025

U should add the test case to the profiles, then make sure it appears in CI summary. Thanks

@szedan-rh szedan-rh marked this pull request as draft November 19, 2025 20:52
@szedan-rh
Copy link
Contributor Author

szedan-rh commented Nov 23, 2025

Screenshot From 2025-11-23 11-35-30

@szedan-rh szedan-rh marked this pull request as ready for review November 23, 2025 09:36
@szedan-rh
Copy link
Contributor Author

szedan-rh commented Nov 23, 2025

@Xunzhuo - Could you please take another look?

@szedan-rh
Change the test localtion to e2e/testcase and remove not needed code …
68be978 
…that was for other tests cases that not done yet.

Signed-off-by: Senan Zedan <[email protected]>
@szedan-rh szedan-rh marked this pull request as draft November 23, 2025 13:07
@szedan-rh
Update keyword routing tests to match reference implementation
0c57774 
Simplified from 31 to 13 tests covering core OR/AND/NOR operators.
Aligned configuration with documented keyword.yaml behavior.
@szedan-rh
Remove accidentally committed test report files
c51ae0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rootfs rootfs rootfs left review comments

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@rootfs rootfs

@Xunzhuo Xunzhuo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szedan-rh @Xunzhuo @rootfs